-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Table Bot Accounts: Remove PAT panel on destroy #860
Conversation
0be4b79
to
1231c5a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this and your code looks great. Just a couple comments.
53c0f6f
to
802eb62
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great. Just left a few comments about possibly changing the route/method names
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Code coverage of files in pull request scope (98.4%)Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
What does this PR do and why?
This PR is a followup to #849, and adds logic to remove the new PAT frame upon bot deletion or revoked PAT. This is because we wouldn't want the new PAT panel to persist upon the potential removal of the PAT itself or its associated bot. Due to the changes in response logic in #849, the PAT frame now uses
data-turbo-permanent
attribute to persist through response refreshes, and requires explicit logic to remove/hide it.Screenshots or screen recordings
Before:
Screencast from 2024-12-19 01:17:14 PM.webm
Now:
Screencast from 2024-12-19 01:17:53 PM.webm
How to set up and validate locally
Repeat for both project and group bots:
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.