-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action policy/speedup #858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
deepsidhu85
force-pushed
the
action_policy/speedup
branch
from
December 13, 2024 15:41
df838f8
to
a51b153
Compare
This comment has been minimized.
This comment has been minimized.
deepsidhu85
force-pushed
the
action_policy/speedup
branch
from
December 20, 2024 16:33
a51b153
to
82df800
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ericenns
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, I just found a couple issues and then a couple suggestions.
…es to get project with namespace and parent namespace for routing
…itialization and use that to determine permissions
…nding on if the params includes group links or not, and to set if the token is active for an uploader.
… to get the effective access level on initialize
…ctive_access_level method which will get the access level if group links are included or not. Reverted changes to views for passing in include_group_links in the context
…horization policy missed in previous commit
…e. Also updated project policy method for transfer sample into project to use the set effective level
…red. Removed commented out code from policies
…to increase coverage
…thod directly which fixed the previous error of undefined method details
deepsidhu85
force-pushed
the
action_policy/speedup
branch
from
January 6, 2025 15:41
c9613bc
to
ea98b5a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…uploader access level with a valid token
Code Metrics Report
Code coverage of files in pull request scope (96.7%)Reported by octocov |
ericenns
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR refactors the project namespace, project, and group policies so that the access level is only retrieved once during the initialization which cuts down on the number of queries to the database.
Some benchmarks from accessing the samples page for
streptococcus
and descendant groups:Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.