Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sapporo CI #853

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix: Sapporo CI #853

merged 2 commits into from
Nov 26, 2024

Conversation

ericenns
Copy link
Member

What does this PR do and why?

Describe in detail what your merge request does and why.

Updates Sapporo CI config to use GET request instead of HEAD to get that sapporo is up before proceeding with tests.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ericenns ericenns self-assigned this Nov 26, 2024
@ericenns ericenns requested a review from deepsidhu85 November 26, 2024 19:09
Copy link

Code Metrics Report

Coverage Test Execution Time
93.2% 9m5s

Reported by octocov

Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing this up

@deepsidhu85 deepsidhu85 marked this pull request as ready for review November 26, 2024 19:24
@deepsidhu85 deepsidhu85 merged commit 08deced into main Nov 26, 2024
4 checks passed
@deepsidhu85 deepsidhu85 deleted the fix/sapporo-ci branch November 26, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants