Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard component for copying PUID's #756

Merged
merged 17 commits into from
Sep 18, 2024
Merged

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Sep 12, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

I created a clipboard view component with stimulusjs controller that allows copying to the clipboard of a specified value with the click of a button. This will help standardize this across all views.

This was added to:

  1. Page Header component on the attribute id
  2. Groups dashboard page, every group puid can be copied

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to the groups dashboard page
  2. On any row click on the copy to clipboard button
  3. Assert that the Copied tooltip was displayed
  4. Try to paste the value somewhere, it should be the puid from the row.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@joshsadam joshsadam self-assigned this Sep 12, 2024
@joshsadam joshsadam force-pushed the puid-copy-to-clipboard branch from 934f9f6 to 381be87 Compare September 12, 2024 22:07

This comment has been minimized.

@joshsadam joshsadam marked this pull request as ready for review September 13, 2024 18:14
@joshsadam joshsadam force-pushed the puid-copy-to-clipboard branch from 2b178cd to 6de0122 Compare September 13, 2024 18:15

This comment has been minimized.

@joshsadam joshsadam added the enhancement New feature or request label Sep 13, 2024
@joshsadam joshsadam force-pushed the puid-copy-to-clipboard branch from 6de0122 to a4ff97c Compare September 17, 2024 16:27

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! No comments from me.

@ericenns ericenns merged commit d54efd9 into main Sep 18, 2024
3 checks passed
@ericenns ericenns deleted the puid-copy-to-clipboard branch September 18, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants