chore: Change h3 to p to fix semantics in empty state component (#285)

* chore: Change h3 to p to fix semantics * chore: Fixed broken test
phac-nml · Oct 30, 2023 · 68b9e2c · 68b9e2c
1 parent 5103ac3
commit 68b9e2c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/components/viral/empty_state_component.html.erb b/app/components/viral/empty_state_component.html.erb
@@ -2,9 +2,9 @@
   <div class="flex items-center inline-block">
     <%= viral_icon(name: icon_name, color: :primary, classes: "w-20 h-20 shrink mr-4") %>
     <div class="flex flex-col grow">
-      <h3 class="text-2xl font-bold dark:text-slate-300 text-slate-700">
+      <p class="text-2xl font-bold dark:text-slate-300 text-slate-700">
         <%= title %>
-      </h3>
+      </p>
       <% if description.present? %>
         <p class="text-slate-600 dark:text-slate-400">
           <%= description %>

diff --git a/test/components/viral/empty_component_test.rb b/test/components/viral/empty_component_test.rb
@@ -7,7 +7,7 @@ class EmptyComponentTest < ViewComponentTestCase
     test 'default' do
       render_preview(:default)
       assert_selector 'span.Viral-Icon svg'
-      assert_selector 'h3', text: I18n.t(:'groups.show.shared_projects.no_shared.title')
+      assert_selector 'p', text: I18n.t(:'groups.show.shared_projects.no_shared.title')
       assert_selector 'p', text: I18n.t(:'groups.show.shared_projects.no_shared.description')
     end
   end