Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v2.4.0 #119

Merged
merged 7 commits into from
Oct 8, 2019
Merged

Prepare release v2.4.0 #119

merged 7 commits into from
Oct 8, 2019

Conversation

peterk87
Copy link
Contributor

@peterk87 peterk87 commented Sep 26, 2019

  • v2.3.0 -> v2.4.0
  • fix setup.py so that project description is rendered properly on PyPI
  • ensure README up-to-date

@peterk87 peterk87 changed the title WIP: Prepare release v2.4.0 Prepare release v2.4.0 Oct 4, 2019
@peterk87 peterk87 requested a review from DarianHole October 4, 2019 15:40
Copy link
Member

@DarianHole DarianHole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the code look good to me. Although I cannot get it to install with pip install like I have been doing previously. The error is coming form the installation of the pyahocorasick import.

Error is: ERROR: Failed building wheel for pyahocorasick

Long error:

ERROR: Command errored out with exit status 1:
   command: /home/darian/miniconda3/envs/test_biohansel_3.6/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-0ayjx838/pyahocorasick/setup.py'"'"'; __file__='"'"'/tmp/pip-install-0ayjx838/pyahocorasick/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-eu51szt8 --python-tag cp36
       cwd: /tmp/pip-install-0ayjx838/pyahocorasick/
  Complete output (9 lines):
  running bdist_wheel
  running build
  running build_ext
  building 'ahocorasick' extension
  creating build
  creating build/temp.linux-x86_64-3.6
  gcc -pthread -B /home/darian/miniconda3/envs/test_biohansel_3.6/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DAHOCORASICK_UNICODE= -I/home/darian/miniconda3/envs/test_biohansel_3.6/include/python3.6m -c pyahocorasick.c -o build/temp.linux-x86_64-3.6/pyahocorasick.o
  unable to execute 'gcc': No such file or directory
  error: command 'gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for pyahocorasick
  Running setup.py clean for pyahocorasick
Successfully built bio-hansel
Failed to build pyahocorasick
Installing collected packages: numpy, six, python-dateutil, pytz, pandas, pyahocorasick, attrs, bio-hansel
  Running setup.py install for pyahocorasick ... error
    ERROR: Command errored out with exit status 1:
     command: /home/darian/miniconda3/envs/test_biohansel_3.6/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-0ayjx838/pyahocorasick/setup.py'"'"'; __file__='"'"'/tmp/pip-install-0ayjx838/pyahocorasick/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-bxq46fsm/install-record.txt --single-version-externally-managed --compile
         cwd: /tmp/pip-install-0ayjx838/pyahocorasick/
    Complete output (9 lines):
    running install
    running build
    running build_ext
    building 'ahocorasick' extension
    creating build
    creating build/temp.linux-x86_64-3.6
    gcc -pthread -B /home/darian/miniconda3/envs/test_biohansel_3.6/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DAHOCORASICK_UNICODE= -I/home/darian/miniconda3/envs/test_biohansel_3.6/include/python3.6m -c pyahocorasick.c -o build/temp.linux-x86_64-3.6/pyahocorasick.o
    unable to execute 'gcc': No such file or directory
    error: command 'gcc' failed with exit status 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/darian/miniconda3/envs/test_biohansel_3.6/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-0ayjx838/pyahocorasick/setup.py'"'"'; __file__='"'"'/tmp/pip-install-0ayjx838/pyahocorasick/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-bxq46fsm/install-record.txt --single-version-externally-managed --compile Check the logs for full command output.

Same error for both python 3.6 and 3.7.

Let me know if there is a different way that I am now supposed to install it and I'll test it thoroughly again

@peterk87
Copy link
Contributor Author

peterk87 commented Oct 8, 2019

unable to execute 'gcc': No such file or directory

@DarianHole If you're running Ubuntu, you might need to install gcc. I usually just apt install build-essential to cover all my bases. Are you trying to pip install -e . into a virtualenv?

@DarianHole DarianHole self-requested a review October 8, 2019 22:58
Copy link
Member

@DarianHole DarianHole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterk87, for the advice there. I just set-up a new computer and don't have much in the way of debugging time at the moment.

As for the code, I am now able to run everything and it works as expected!

@DarianHole DarianHole merged commit 34d3a46 into development Oct 8, 2019
@peterk87 peterk87 deleted the dev/2.4.0 branch October 9, 2019 14:26
@peterk87
Copy link
Contributor Author

peterk87 commented Oct 9, 2019

Thanks @DarianHole for having a look and verifying that things work for you! Time to merge into master and create a new release.

@peterk87 peterk87 mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants