Fix locking rows when partitioning with a lock timeout #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
partition_data_proc()
orpartition_data_time()
with a non-zero value forp_lock_wait
, the query generated to lock the rows for updating incorrectly includes the table name where it should be includingp_partition_expression
. This PR fixes that issue by indexing the correct argument toformat
.I don't have a setup to test this, but I ran into this in a production environment while trying to understand why moving data from the default partition didn't appear to be making any progress. I also didn't write any tests because I wasn't sure what minimum level of SQL would be necessary for testing this. Hopefully that's not an issue for getting this merged.
Ultimately this isn't blocking my progress, but I figured I would make this quick update. Let me know if you want me to make any updates to the CHANGELOG or any other files.