Skip to content

Commit

Permalink
address review comments:
Browse files Browse the repository at this point in the history
add tests for sub-partitioning with uuid7 column
improve test comments to describe column data types clearly
  • Loading branch information
akulapid committed Nov 19, 2024
1 parent 1bee500 commit c37290a
Show file tree
Hide file tree
Showing 6 changed files with 712 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/test-text-time-subpart-custom-start.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-- ########## NATIVE ID PARENT / TIME SUBPARENT TESTS ##########
-- ########## NATIVE ID PARENT / TEXT SUBPARENT TESTS ##########
-- Additional tests: no pg_jobmon
-- Test using a pre-created template table and passing to create_parent. Should allow indexes to be made for initial children.
-- additional constraint column
Expand Down
2 changes: 1 addition & 1 deletion test/test-text-time-subpart-native.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-- ########## TIME PARENT / ID SUBPARENT NATIVE TESTS ##########
-- ########## TEXT PARENT / ID SUBPARENT NATIVE TESTS ##########
-- Additional tests:
-- Set analyze to true for maintenance
-- Premake template table and ensure pk is made on initial child tables
Expand Down
2 changes: 1 addition & 1 deletion test/test-uuid-daily.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-- ########## TIME DAILY TESTS ##########
-- ########## UUID7 DAILY TESTS ##########
-- Other tests:
-- Privilege inheritance
-- check that maintenance catches up if tables are missing
Expand Down
2 changes: 1 addition & 1 deletion test/test-uuid-gap-fill.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-- ########## TIME DAILY TESTS ##########
-- ########## UUID7 DAILY TESTS ##########
-- Other tests: test that gap in child tables backfill works
-- Test using default template table. Initial child tables will have no indexes. New tables after template has indexes added should.

Expand Down
Loading

0 comments on commit c37290a

Please sign in to comment.