-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub-transactions API #912
base: develop
Are you sure you want to change the base?
Sub-transactions API #912
Commits on Dec 5, 2022
-
Problem: inability to fine-tune transaction boundaries easily
Solution: implement an interface for sub-transactions It's a fairly simplistic interface at this point and it allows choosing a mode of release on drop (commit by default). This is an improved version of the original implementation in pgx-contrib-spiext (https://github.com/supabase/pgx-contrib-spiext/blob/main/src/subtxn.rs)
Configuration menu - View commit details
-
Copy full SHA for f7455b1 - Browse repository at this point
Copy the full SHA f7455b1View commit details
Commits on Dec 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a35d24e - Browse repository at this point
Copy the full SHA a35d24eView commit details -
Problem: manual implementation of Drop for SubTransaction
It may be unnecessary. Solution: simply derive it
Configuration menu - View commit details
-
Copy full SHA for aa8ae18 - Browse repository at this point
Copy the full SHA aa8ae18View commit details -
Problem: SubTransactionExt::T is a non-descriptive name
Solution: name it Parent as it is what it is
Configuration menu - View commit details
-
Copy full SHA for 8998091 - Browse repository at this point
Copy the full SHA 8998091View commit details -
Problem: SubTransaction::memory_context() is not used anywhere
Also, given `PgMemoryContexts` API is still somewhat rough, it may be not a great idea to expose it. Solution: remove it
Configuration menu - View commit details
-
Copy full SHA for 351d157 - Browse repository at this point
Copy the full SHA 351d157View commit details -
Problem: unclear what a null argument to BeginInternalSubTransaction …
…is for Solution: comment it
Configuration menu - View commit details
-
Copy full SHA for b38d9d7 - Browse repository at this point
Copy the full SHA b38d9d7View commit details -
Problem: unclear how ResourceOwner should be managed
Solution: provide some reference materials on it
Configuration menu - View commit details
-
Copy full SHA for df654a1 - Browse repository at this point
Copy the full SHA df654a1View commit details
Commits on Dec 14, 2022
-
Problem: use of Option<Parent> in SubTransaction
It is only there so that we can move it out of manually copied type that implements Drop Solution: extract release logic into a separate trait
Configuration menu - View commit details
-
Copy full SHA for d04aea8 - Browse repository at this point
Copy the full SHA d04aea8View commit details -
Problem: meaning of fields in SubTransaction is unclear
Solution: document them
Configuration menu - View commit details
-
Copy full SHA for 1cc57bc - Browse repository at this point
Copy the full SHA 1cc57bcView commit details
Commits on Jan 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3ed2afe - Browse repository at this point
Copy the full SHA 3ed2afeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94f7cf8 - Browse repository at this point
Copy the full SHA 94f7cf8View commit details
Commits on Jan 19, 2023
-
Problem: prelude exports too much from subxact
We can do better Solution: export only most common types
Configuration menu - View commit details
-
Copy full SHA for cb812f4 - Browse repository at this point
Copy the full SHA cb812f4View commit details