Removes pg10 support #830
Merged
Removes pg10 support #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes some pg10 generated files * Touches up on some docs * Removes 10 from SUPPORTED_MAJOR_VERSIONS so cargo pgx init won't download and use pg10
|
@BradyBonnette Do you think dropping Postgres 11 as well is worth it? |
|
@workingjubilee tbh I am not sure that is my call. I can certainly remove it here in addition to pg10, but I think I'd want to hear from @eeeebbbbrrrr first. |
syvb
reviewed
Oct 31, 2022
There was a problem hiding this comment.
pgx-pg-sys/include/pg10.h can be deleted now.
Also, this line from the README needs to be updated:
|
@Smittyvb good catch, thanks :) Ill do that right now. |
* Removes pgx-pg-sys/include/pg10.h * Updates cargo pgx README.md
This was referenced Oct 31, 2022
syvb
reviewed
Nov 1, 2022
cargo-pgx/README.md
Outdated
| @@ -504,7 +503,7 @@ test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; fini | |||
| Stopping Postgres | |||
| ``` | |||
|
|
|||
| `cargo pgx test [pg10 | pg11 | pg12 | pg13 | pg14 | pg15]` runs your `#[test]` and `#[pg_test]` annotated functions using cargo's test system. | |||
| `cargo pgx test pg11 | pg12 | pg13 | pg14 | pg15]` runs your `#[test]` and `#[pg_test]` annotated functions using cargo's test system. | |||
There was a problem hiding this comment.
missing a character here:
Suggested change
| `cargo pgx test pg11 | pg12 | pg13 | pg14 | pg15]` runs your `#[test]` and `#[pg_test]` annotated functions using cargo's test system. | |
| `cargo pgx test [pg11 | pg12 | pg13 | pg14 | pg15]` runs your `#[test]` and `#[pg_test]` annotated functions using cargo's test system. |
eeeebbbbrrrr
approved these changes
Nov 1, 2022
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.