Let bindgen know which traits Datum implements #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
changed the title
|
FYI apparently bindgen only supports calling |
In #545 we replaced `Datum`'s autogenerated bindings with an opaque pointer. Because bindgen was not generating the type, it could not know which traits `Datum` implements. This changed how containers of `Datum` were emitted. In particular containers of `Datum` no longer derived `Debug`, `Copy`, or `Clone`. This also affected how unions containing these containers were emitted: bindgen only uses Rust unions if all members are `Copy`, falling back to a struct of `__BindgenUnionField<_>` fields otherwise. This change tells bindgen which traits our `Datum` implementation implements, fixing all of the above issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #545 we replaced
Datum's autogenerated bindings with an opaque pointer. Because bindgen was not generating the type, it could not know which traitsDatumimplements. This changed how containers ofDatumwere emitted. In particular containers ofDatumno longer derivedDebug,Copy, orClone. This also affected how unions containing these containers were emitted: bindgen only uses Rust unions if all members areCopy, falling back to a struct of__BindgenUnionField<_>fields otherwise.This change tells bindgen which traits our
Datumimplementation implements, fixing all of the above issues.