Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate tuple udf #686

Closed
wants to merge 3 commits into from
Closed

Eliminate tuple udf #686

wants to merge 3 commits into from

Conversation

willmurnane
Copy link
Contributor

There's a lot of song and dance about how functions which return a single tuple are turned into something that Postgres can call. This eliminates that: when a function which returns a tuple is discovered, the func_call is rewritten into an iterator on the spot, and then it's treated as if it were a function which returns an iterator (and thus passes through the impl_table_srf function). This removes:

  • the impl_tuple_udf function
  • the tuple return type of item_fn
  • the edge case of "this might not need a pg_guard"

Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with #615, which may still yet receive final-pass revisions. It cannot land before then, and after #615 does, I will be pushing towards 0.5.0.

@willmurnane
Copy link
Contributor Author

Closing in favor of #685. Now that #615 has landed, all of these functions are unused and can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants