Hang onto libraries #573
Merged
Hang onto libraries #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
eeeebbbbrrrr
approved these changes
May 25, 2022
This was referenced Jun 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #572 we discovered that on glibc 2.17 (notably, CentOS 7) there appears to be some surprising behavior around dropping the
libloading::os::unix::Librarystructures, theDropimplementation callsdlclosewhich is... notably a "challenged" call.This these structures are already used for the remaining duration of the
cargo-pgxbinary execution, there is no harm in keeping them around until they can be part of the normal program drops on exit instead. This avoids the issue sufficiently in my testing.