Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding post_parse_analyze hook #542

Conversation

hamin
Copy link

@hamin hamin commented Apr 15, 2022

No description provided.

@eeeebbbbrrrr
Copy link
Contributor

I replied on discord with this:

I’m on yet another road trip today but it looks like you hand-edited the bindings files. Instead, update the includes/*.h files to pull in the Postgres header with the new symbols

The bindings .rs files we keep in git are to appease docs.rs builds and are not used at all during normal compilation processes. Which is why you’re getting the undefined symbol errors

@Hoverbear
Copy link
Contributor

(This PR seems abandoned, closing)

@Hoverbear Hoverbear closed this Jun 28, 2022
@hamin
Copy link
Author

hamin commented Jun 28, 2022

@Hoverbear sorry been busy with work and have vacation coming up tomorrow for a few weeks. I think I can get back to this on mid july. What's the protocol? Open a. new PR or reopen this PR when i'm ready?

Thanks in advance!

@Hoverbear Hoverbear reopened this Jun 29, 2022
@Hoverbear
Copy link
Contributor

@hamin It's no problem! :) We'd still be happy to merge when you got time to make it work via the headers as discussed. You can always ping us if you want some help.

I really hope you enjoy your vacation and get to do everything you desire on it! If you don't get back to this until after, it's ok. Relaxing comes first on vacation.

@workingjubilee
Copy link
Member

An updated variant of this PR landed in #800. Thank you!

@hamin
Copy link
Author

hamin commented Nov 3, 2022

@workingjubilee No worries! Was thinking about getting back on this work last week! But glad its in so I can pick up my pet project again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants