Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --pgcli #538

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Support --pgcli #538

merged 4 commits into from
Apr 19, 2022

Conversation

Hoverbear
Copy link
Contributor

I prefer pgcli to psql in many cases. This PR adds support for it on cargo pgx run and cargo pgx connect.

image

@Hoverbear
Support --pgcli on connect/run
73402bc 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear
fmt
dfe8c99 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear Hoverbear self-assigned this Apr 11, 2022
@Hoverbear Hoverbear changed the title Pgcli Support --pgcli Apr 11, 2022
eeeebbbbrrrr
eeeebbbbrrrr requested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update cargo-pgx/README.md to explain how to use this, then this looks good to merge.

eeeebbbbrrrr
eeeebbbbrrrr approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge

@Hoverbear Hoverbear merged commit 2075d0e into develop Apr 19, 2022
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Apr 19, 2022
Merged
@eeeebbbbrrrr eeeebbbbrrrr deleted the pgcli branch June 20, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeeebbbbrrrr eeeebbbbrrrr eeeebbbbrrrr approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @eeeebbbbrrrr