Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pg_authid #527

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

nikkhils
Copy link
Contributor

@nikkhils nikkhils commented Apr 4, 2022

Add entries for pg_authid catalog table in all versions

@eeeebbbbrrrr
Copy link
Contributor

These .rs bindings files are auto-generated (and we only store them in git to appease docs.rs builds).

Instead of hand-editing them, please add the appropriate header files to each of the .h files here: https://github.com/tcdi/pgx/tree/master/pgx-pg-sys/include

@nikkhils
Copy link
Contributor Author

nikkhils commented Apr 4, 2022

@eeeebbbbrrrr that's much easier, thanks. Will re-submit. However, who will add the entries in the Rust files? Should I keep the ones I have added around or remove them in this PR and only have the .h changes?

@eeeebbbbrrrr
Copy link
Contributor

It happens automatically during compilation. Like I said, those .rs files only exist to make docs.ra website happy.

@nikkhils
Copy link
Contributor Author

nikkhils commented Apr 4, 2022

@eeeebbbbrrrr great. I have re-submitted with just the header file changes

@Hoverbear Hoverbear changed the base branch from master to develop April 4, 2022 16:20
@eeeebbbbrrrr
Copy link
Contributor

can you please do one other thing and update your fork from what's currently on tcdi/pgx? I screwed up our git history, and that's why this PR is showing 204 files changed.

Add entries for pg_authid catalog table in all versions
@nikkhils
Copy link
Contributor Author

nikkhils commented Apr 5, 2022

can you please do one other thing and update your fork from what's currently on tcdi/pgx? I screwed up our git history, and that's why this PR is showing 204 files changed.

Done!

@nikkhils
Copy link
Contributor Author

nikkhils commented Apr 7, 2022

@eeeebbbbrrrr is there anything else I need to do here? Also if everything is ok, when will this be merged into dev and when it will be part of a release? TIA.

@Hoverbear
Copy link
Contributor

@nikkhils Thanks! I'll merge this and you can expect it in our next release. :)

@Hoverbear Hoverbear merged commit 4cc6a13 into pgcentralfoundation:develop Apr 7, 2022
@nikkhils nikkhils deleted the pg_auth branch April 8, 2022 12:10
@nikkhils nikkhils restored the pg_auth branch April 8, 2022 12:10
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants