Add appendinfo.h and regenerate bindings #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to have upgraded bindings to 12.10 from 12.9. appendinfo.h contains a couple of methods used for foreign data wrappers. In particular `add_row_identity_var` is referenced from the official postgres documentation, and is nice to have here.
|
@einarmo this looks good overall, however it is kind of our policy to include the same things wherever possible. Could I ask you to add the includes for |
It does not seem to exist for pg10 and pg11.
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to have upgraded bindings to 12.10 from 12.9, among other things.
appendinfo.h contains a couple of methods used for foreign data wrappers. In particular
add_row_identity_varis referenced from the official postgres documentation, and is nice to have here.The file exists for pg12 and pg13 as well, but it's just the
add_row_identity_varmethod first added in pg14 which seem generally useful here. I think only that method is needed for external applications in practice.