Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace support #475

Merged
merged 8 commits into from
Mar 16, 2022
Merged

Workspace support #475

merged 8 commits into from
Mar 16, 2022

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Mar 8, 2022 •
edited
Loading

This adds package-id support (--package) to most cargo-pgx commands, it also supports --manifest-path, like cargo.

@Hoverbear
Copy link
Contributor Author

Noting this is not for 0.4.0

@Hoverbear Hoverbear marked this pull request as ready for review March 14, 2022 21:48
@Hoverbear
Copy link
Contributor Author

We did not end up adding --workspace as the only one that made sense was cargo pgx test --workspace but that had numerous restrictions and channels since we couldn't support concepts like two extensions having differing pgversions for their feature flags, etc.

@Hoverbear
Copy link
Contributor Author

Turns out we are merging this for 0.4.0!

@Hoverbear Hoverbear merged commit db6843e into develop Mar 16, 2022
@Hoverbear Hoverbear mentioned this pull request Mar 16, 2022
Merged
@Hoverbear Hoverbear mentioned this pull request Mar 30, 2022
Merged
@eeeebbbbrrrr eeeebbbbrrrr deleted the workspace-support branch June 20, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hoverbear