Generate pgx-pg-sys bindings based on features #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
|
Here's comparing the CPU load for a ZomboDB build between #441 and this PR (which builds atop it since it's merged to Before:
After:
|
|
LGTM. However, please retarget this PR to the |
|
This also improves errors when a feature isn't specified: |
Signed-off-by: Ana Hobden <[email protected]>
This was referenced Mar 2, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #452 .
Please note these performance measurements are done on a 32 core machine which was not previously CPU bound, and still is not CPU bound, so the gains between "generating all bindings" and "generating one binding" is quite small. On a machine with less cores (or doing other things) these gains would be more noticeable.
Here's with generating all bindings:
While doing just one feature:
As discussed in #452, this adjusts the
update-versions.shscript to make it regenerate the bindings (and build all packages to make sure they aren't broken)