Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow compilation on OpenBSD #359

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Allow compilation on OpenBSD #359

merged 2 commits into from
Apr 19, 2022

Conversation

ledeuns
Copy link
Contributor

@ledeuns ledeuns commented Jan 3, 2022

Two changes to allow to build pgx on OpenBSD :

  • pgx requires GNU make. Base make is BSD make so we need to pass gmake (via an envvar)
  • OpenBSD has sigsetjmp

@Hoverbear Hoverbear self-requested a review January 3, 2022 20:14
@Hoverbear Hoverbear self-assigned this Jan 3, 2022
Hoverbear
Hoverbear reviewed Jan 3, 2022
View reviewed changes
pgx-pg-sys/build.rs Outdated Show resolved Hide resolved
@JamesGuthrie
Copy link
Contributor

FYI If you're planning on using schema generation on OpenBSD then you're probably going to need to add it as a target to https://github.com/zombodb/pgx/blob/master/cargo-pgx/src/templates/cargo_config. See #362 and #340 for more context.

@eeeebbbbrrrr
Copy link
Contributor

Can be merged now?

I don't think @JamesGuthrie's comment (#359 (comment)) is relevant anymore as we now have a far superior sql generation process.

@Hoverbear Hoverbear changed the base branch from master to develop April 19, 2022 17:06
@eeeebbbbrrrr eeeebbbbrrrr merged commit 584a584 into pgcentralfoundation:develop Apr 19, 2022
@eeeebbbbrrrr
Copy link
Contributor

We're gonna ship this but don't have a way to test.

@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Apr 19, 2022
Merged
@ledeuns
Copy link
Contributor Author

ledeuns commented Apr 19, 2022

I can confirm it works on OpenBSD 7.1. Thank you !

@eeeebbbbrrrr
Copy link
Contributor

Amazing! Thanks a bunch for testing and of course this PR. I’m glad we made the changes that accidentally got it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear left review comments

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ledeuns @JamesGuthrie @eeeebbbbrrrr @Hoverbear