Add BorrowDatum for unsizing borrows of datums
#1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
force-pushed
the
add-borrow-datum
branch
from
5e3526a
to
ed6886d
Compare
workingjubilee
commented
Sep 29, 2024
workingjubilee
commented
Sep 29, 2024
YohDeadfall
reviewed
Sep 29, 2024
| } | ||
| } | ||
|
|
||
| unsafe fn unbox_nullable_arg(arg: Arg<'_, 'fcx>) -> Nullable<Self> { |
There was a problem hiding this comment.
Nullable is a kind of Option, and methods returning an option and their unchecked variants have the same names not counting the suffix. I would move in that direction.
There was a problem hiding this comment.
I haven't determined yet if I want the base to be a Result type.
YohDeadfall
reviewed
Sep 29, 2024
|
Current main unknown: does this trait need a lifetime in order to provide a correct API...? Or should I just enforce that in interfaces like |
YohDeadfall
approved these changes
Sep 30, 2024
workingjubilee
force-pushed
the
add-borrow-datum
branch
from
491d144
to
b86e747
Compare
workingjubilee
commented
Oct 1, 2024
| /// are implementing a varlena type. As the other dynamic length type, CStr also does this. | ||
| /// This function | ||
| /// - must NOT mutate the pointee | ||
| /// - must point to the entire datum's length (`size_of_val` must not lose bytes) |
There was a problem hiding this comment.
It may be fine if we relax this requirement eventually.
eeeebbbbrrrr
added a commit
that referenced
this pull request
Oct 14, 2024
Welcome to pgrx v0.12.6. This releases fixes a number of bugs, cleans up various parts of the code, adds more Postgres `#include` headers, and other little things. To upgrade, first install cargo-pgrx with `cargo install cargo-pgrx --version 0.12.6 --locked`. Then you can run `cargo pgrx upgrade` in your extension's crate to update its dependencies. ## What's Changed * Removed extra allocation from `IntoDatum for char` by @YohDeadfall in #1887 * Fixed IntoDatum impl for char introduced by #1887 by @YohDeadfall in #1889 * Support refs to unsized SqlTranslatable types by @workingjubilee in #1890 * Nullable is Copy when T is Copy by @workingjubilee in #1884 * Macro based IntoDatum for string types by @YohDeadfall in #1886 * `impl FromDatum for CString` by @workingjubilee in #1896 * Add `BorrowDatum` for unsizing borrows of datums by @workingjubilee in #1891 * Always panic if len of varlena exceeds the maximum by @YohDeadfall in #1894 * Use cstr literal syntax to avoid unsafe and ??? by @workingjubilee in #1898 * Implement UnboxDatum for ItemPointerData by @syvb in #1900 * fix compilation on some CPUs and Windows by @usamoi in #1901 * docs: update generic type name of TableIterator by @SteveLauC in #1905 * Remove Python workaround for Homebrew by @workingjubilee in #1908 * Improved messages for json errors by @YohDeadfall in #1893 * Adds more headers by @aykut-bozkurt in #1910 * docs: align description of GucContext::SuBackend and GucContext::Backend with original PostgreSQL description by @mrl5 in #1909 * docs: update outdated README by @SteveLauC in #1914 * fix compilation on emscripten by @usamoi in #1917 * feat: include 'storage/indexfsm.h' by @SteveLauC in #1912 * refactor: more CStr literals by @SteveLauC in #1911 * fix segfault with empty `numrange` during `from_datum()` by @eeeebbbbrrrr in #1918 ## New Contributors * @mrl5 made their first contribution in #1909 **Full Changelog**: v0.12.5...v0.12.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a trait that allows borrowing Datums from various places, like arguments and arrays, instead of always taking them by-value. This is most important for unsizing borrows, as the sized kind are a simple
.cast()away.The motivating rationale is to enable new APIs in the near future like FlatArray and Text. It also brings in some more uniformity because of the blanket-impl of ArgAbi for
&T. This means that various types that are pass-by-reference may now actually be taken by reference from their Datum, instead of copying them into the Rust function! This is more important for unsized types, but for various reasons, right now it only takes over the ArgAbi of one unsized type: CStr.