use cc to generate cshim #1854
Merged
use cc to generate cshim #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am so glad I added that packaging check. |
|
It catches only the weirdest, silliest issues, but man, pgrx sure does have plenty of those. |
Co-authored-by: Jubilee <[email protected]>
|
👀, @eeeebbbbrrrr ? |
eeeebbbbrrrr
approved these changes
Sep 18, 2024
|
I’m sorry. I looked at this when it came in and then… who knows! I like it. I’ll let @workingjubilee press the merge button, but this LGTM. |
|
Oh. Does this add any new system dependencies, I don’t guess it would but wanted to ask. |
|
It should effectively reduce them since we no longer need to know about pgxs.mk to build the cshim. |
|
Hmm. Neat. would be nice if we could drop the cshim entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should enable cross-compiling if
cshimfeature is enabled. It's tested on my machine and it works correctly.