Added into_iter for anyarray #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should there be a consuming iterator or this one is enough? |
|
honestly I expected IntoIterator would have been for AnyArray and be consuming, yeah. |
|
Also, to be clear, |
|
We discussed this and this is probably fine as-is. |
daamien
pushed a commit
to daamien/pgrx
that referenced
this pull request
Sep 12, 2024
Fixes pgcentralfoundation#1832. The implementation isn't what I want, but it adds `into_iter` for `&AnyArray` and I hope unblocking thomcc. Later it would be better to get rid of `AnyArray` in its current state and use `Array<AnyElement>` instead, I will investigate that possibility. But for now that is how it is and without any breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1832.
The implementation isn't what I want, but it adds
into_iterfor&AnyArrayand I hope unblocking @thomcc. Later it would be better to get rid ofAnyArrayin its current state and useArray<AnyElement>instead, I will investigate that possibility. But for now that is how it is and without any breaking change.