-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixups of issues left from #1837 #1843
Merged
workingjubilee
merged 2 commits into
pgcentralfoundation:develop
from
YohDeadfall:fixups
Sep 6, 2024
Merged
Fixups of issues left from #1837 #1843
workingjubilee
merged 2 commits into
pgcentralfoundation:develop
from
YohDeadfall:fixups
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I see. It contains the desired output inside, but the message looks a bit cryptic:
|
...a bit cryptic indeed, yes. |
eeeebbbbrrrr
added a commit
that referenced
this pull request
Sep 9, 2024
Welcome to pgrx v0.12.3. This point release upgrades to use the new Postgres 17rc1. As usual, please `cargo install cargo-pgrx --version 0.12.3 --locked`. Then you can run `cargo pgrx upgrade` in your extension crate's root to update its dependencies. ## What's Changed * Fixups of issues left from #1837 by @YohDeadfall in #1843 * move to Postgres v17rc1 by @eeeebbbbrrrr in #1846 **Full Changelog**: v0.12.2...v0.12.3
daamien
pushed a commit
to daamien/pgrx
that referenced
this pull request
Sep 12, 2024
Welcome to pgrx v0.12.3. This point release upgrades to use the new Postgres 17rc1. As usual, please `cargo install cargo-pgrx --version 0.12.3 --locked`. Then you can run `cargo pgrx upgrade` in your extension crate's root to update its dependencies. ## What's Changed * Fixups of issues left from pgcentralfoundation#1837 by @YohDeadfall in pgcentralfoundation#1843 * move to Postgres v17rc1 by @eeeebbbbrrrr in pgcentralfoundation#1846 **Full Changelog**: pgcentralfoundation/pgrx@v0.12.2...v0.12.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues left from #1837, but nothing critical.
The problem with
unreachable!
in tests is that it requires to have a non-emptyexpected
in the#[should_panic]
attribute. So we provide a message to verify that panicking happens for the right reason.