document pg_guard to the best of my abilities #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+13
to
+14
| Code execution then finds its way to `errfinish()` where, finally, `siglongjmp()` is called to instantly move the stack | ||
| back to the frame where Postgres began the current transaction (where it previously created a `sigsetjmp()` point). |
There was a problem hiding this comment.
Hmm. This should probably clarify that it moves the state to that exact point-in-time of the sigsetjmp, "right after" it was called.
There was a problem hiding this comment.
I think I understand what you mean, but I'm not quite sure of the words you'd want to explain it. I'll let you add this point. ;)
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
|
@workingjubilee I think this is good enough. I left #1729 (comment) for you. As I said, I'm not quite sure how you'd want that to be explained. |
workingjubilee
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1406