New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten up `Pg_magic_func` code #1423

Merged

workingjubilee merged 3 commits into pgcentralfoundation:develop from workingjubilee:unify-pgrx-magic-func

Dec 6, 2023

Member

workingjubilee commented Dec 5, 2023 •

edited

Loading

Aside from making things easier to fit on a page and thus read, this:

reduces shadowing-crate-name concerns
eliminates someone actually calling initialize() (technical API break)
technically does not prevent anyone from calling our panic hook fn, anyways


          Unify Pgrx_magic_func code

870b46e

Tighten it up in the process to minimize shadowing-crate-name concerns.

workingjubilee added the breaks-API label

workingjubilee added 2 commits

December 5, 2023 14:52


          2 more loc

1200f46


          Remove unused prelude

4f4481f

workingjubilee merged commit 7a1b922 into pgcentralfoundation:develop

8 checks passed

workingjubilee deleted the unify-pgrx-magic-func branch

December 6, 2023 00:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels