Weaken bounds on Array impls #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This weakens the bounds on various implementations for Array. It's utterly useless because you still can't construct such an array.
workingjubilee
commented
Oct 27, 2023
pgrx/src/datum/into.rs
Outdated
Comment on lines
37
to
39
| fn array_type_oid() -> pg_sys::Oid { | ||
| unsafe { pg_sys::get_array_type(Self::type_oid()) } | ||
| } |
There was a problem hiding this comment.
This is technically a breaking change.
|
Actually, I think I'll separate that out. |
workingjubilee
force-pushed
the
weaken-array-bounds
branch
from
c74010e
to
cca0bc2
Compare
thomcc
approved these changes
Oct 27, 2023
| let Array { raw, .. } = self; | ||
| // Wrap the Toast<RawArray> to prevent it from deallocating itself | ||
| let mut raw = core::mem::ManuallyDrop::new(raw); | ||
| let ptr = raw.deref_mut().deref_mut() as *mut RawArray; |
There was a problem hiding this comment.
you didn't add this, but lol.
workingjubilee
added a commit
that referenced
this pull request
Oct 28, 2023
This does more cleanup in the vein of weakening needless bounds. - #1355 The "main point" is some no-op "make clippy happy" refactoring. This permits running `cargo clippy` without getting *errors* (it still issues literally hundreds of warnings) on most of the repository's crates. It does not solve this for `pgrx` itself, as clippy detected a more serious issue there, and that issue is instead its own PR: - #1357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaken the bounds on various implementations for Array, to make things easier to refactor. In that vein, clean up a function from on IntoDatum that can be inside Array's IntoDatum impl.
This weakening is mostly irrelevant because you still can't construct such an Array.