(cargo-pgrx init) Use toml serializer to write config.toml #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing the toml by formatting strings meant that on Windows, backslashes in paths weren't escaped, outputting invalid toml. This uses the
toml
crate and the existingConfigToml
struct to read/write the file intead.Also in the readme it says
That was a bit confusing to me, as e.g. running:
$ cargo pgrx init --pg12 download --pg13 download
Followed by
$ cargo pgrx init --pg13 download --pg14 download
Would "erase" the pg12 checkout from the config.toml file, even though the files remained there.
I took that as accidental and fixed it (ie, we read the config and modify it) in this PR, but of course can revert that bit if it was intentional.