Fixes macos-11 tests #1196
Closed
Fixes macos-11 tests #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
reviewed
Jul 7, 2023
| brew install sccache | ||
| mkdir -p /Users/runner/Library/Caches/Mozilla.sccache | ||
| curl -L https://github.com/mozilla/sccache/releases/download/v0.5.4/sccache-v0.5.4-x86_64-apple-darwin.tar.gz | tar xz | ||
| mv -f sccache-v0.5.4-x86_64-apple-darwin/sccache /usr/local/bin |
There was a problem hiding this comment.
I would like it if we could avoid this becoming stale. I don't see an easy fix for this though, so @BradyBonnette, do you mind subscribing to the github notifications for new sccache releases and keeping this up to date?
(I would volunteer but rust project stuff overwhelms my github notification box, and I'd definitely fail to notice a release)
There was a problem hiding this comment.
There might be something we could do internally. Ill take this conversation into Discord because there are considerations here.
|
This needs to go into |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
brewsuddenly stopped working on macos-11 GHA instances. The only place we were using brew was to installsccache, so these changes remove the use of brew to install sccache and instead install sccache manually. These changes also run all tests on macos-11 instead of selective tests.NOTE: This PR is targeting
tcdi:mastersince they're just CI changes.