prepare v0.9.6 #1178
Merged
prepare v0.9.6 #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just going to regular-merge this straight into |
eeeebbbbrrrr
commented
Jun 20, 2023
| @@ -63,7 +63,7 @@ impl TryFrom<pg_sys::Datum> for Date { | |||
|
|
|||
| #[inline] | |||
| fn try_from(datum: pg_sys::Datum) -> Result<Self, Self::Error> { | |||
| pg_sys::DateADT::try_from(datum.value() as isize).map(|d| Date(d)) | |||
| Ok(Date(datum.value() as pg_sys::DateADT)) | |||
There was a problem hiding this comment.
This is the reason for this release.
workingjubilee
approved these changes
Jun 20, 2023
|
Also passed locally on... wait for it... Ubuntu! But sure, I'll wait out the macos job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an "out of band" patch release for a v0.9.6, based directly off v0.9.5. This release fixes a bug with
DatumtoDateconversions. Unfortunately, this bug essentially manifests itself as a Y2K bug where dates prior to 2000-01-01, when used in anArray<Date>fail to convert.When updating, please make sure to
cargo install cargo-pgrx --lockedand update your crate dependencies to v0.9.6.What's Changed
pg_sys::Datuminto apgrx::Date#1177: Cast Date Datums topg_sys::DateADT(i32) instead ofisize)