Fix version check #1157
Merged
Fix version check #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let output = match std::process::Command::new(rustc).arg("--verbose").output() { | ||
| let output = match std::process::Command::new(rustc).arg("--version").output() { |
There was a problem hiding this comment.
that's a hilarious bug.
$ rustc --verbose
error: no input filename given
$ rustc --version
rustc 1.69.0 (84c898d65 2023-04-16)
Both of those pass the conditional at the end of the function. 🤦
eeeebbbbrrrr
approved these changes
Jun 2, 2023
| let output = match std::process::Command::new(rustc).arg("--verbose").output() { | ||
| let output = match std::process::Command::new(rustc).arg("--version").output() { |
There was a problem hiding this comment.
that's a hilarious bug.
$ rustc --verbose
error: no input filename given
$ rustc --version
rustc 1.69.0 (84c898d65 2023-04-16)
Both of those pass the conditional at the end of the function. 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to add a version check to plrust, so I started by copying the last time I wrote a version check. Turns out, last time I wrote it, I got it wrong, so this fixes that.