Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't free the backing Array Datum pointer on drop, even if it was detoasted #1149

Merged
merged 1 commit into from
May 26, 2023
Merged

don't free the backing Array Datum pointer on drop, even if it was detoasted #1149

merged 1 commit into from
May 26, 2023

Conversation

eeeebbbbrrrr
Copy link
Contributor

No description provided.

@eeeebbbbrrrr eeeebbbbrrrr requested a review from thomcc May 26, 2023 15:21
thomcc
thomcc approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is unfortunate, but could be worse.

@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request May 26, 2023
Closed
@eeeebbbbrrrr eeeebbbbrrrr merged commit 6382948 into develop May 26, 2023
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request May 26, 2023
Merged
@eeeebbbbrrrr eeeebbbbrrrr deleted the issue-971-no-free-on-drop branch June 20, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeeebbbbrrrr @thomcc