Fixup iterator impls for Array #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
count, nth, and size_hint did not account for element exhaustion.
thomcc
reviewed
Apr 20, 2023
It will be made incorrect by zero-copy arrays.
|
In the further direction of "these PRs actually relate to each other more than I thought", the other one has a conflicting (necessary) edit with the "reduce unsafe" commit, so I am going to drop that one. |
workingjubilee
force-pushed
the
joy/fixing-array-iterator-impls
branch
from
f83a54e
to
caae6aa
Compare
eeeebbbbrrrr
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a bunch of small problems in these.
This is unrelated to, and thus can be landed in parallel with, the zero-copy Array work. No point in gunking up an already-large PR with additional work.