Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to pgrx #1107

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Conversation

eeeebbbbrrrr
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr commented Apr 17, 2023

This does the needful behind issue #1106

Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed the article question, which was the only serious question I had.

@eeeebbbbrrrr
Copy link
Contributor Author

We discussed the article question, which was the only serious question I had.

yeah, I think it's fine for the files in ./articles/ to get the rename treatment too, since they're under source control.

Published versions on corporate blog can be looked at later, or even never.

#
# Note that "PG_MAJOR_VER" build arg in the build step must match the
# "--features pgXX" in the run step
# "--features pgrxX" in the run step
Copy link
Contributor

@syvb syvb Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and all the other instances of pgXX) shouldn't be changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. thanks. we're still reviewing this too.

@workingjubilee
Copy link
Member

Yeah, that seems fine, and it definitely seems lower priority now that I realize the tcdioss website won't automatically update.

Maybe we should open an issue to track following up on that and making a final decision. But "we discussed it and made a decision that will suffice for now" was the main thing I wanted.

[[email protected]]: https://crates.io/crates/pgrxa
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link was wrong in the orignal too. we'll fix it in post.

@eeeebbbbrrrr
Copy link
Contributor Author

Alrighty, this is going to master right now as a squash merge, then merged into develop, then the repo here on GitHub will be renamed. Then published to crates.io from the master branch.

@eeeebbbbrrrr eeeebbbbrrrr merged commit 8726d4f into pgcentralfoundation:master Apr 17, 2023
@eeeebbbbrrrr eeeebbbbrrrr deleted the rename-to-pgrx branch June 20, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants