-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to pgrx #1107
Rename to pgrx #1107
Conversation
…search-n-replace, that's pretty good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed the article question, which was the only serious question I had.
yeah, I think it's fine for the files in Published versions on corporate blog can be looked at later, or even never. |
# | ||
# Note that "PG_MAJOR_VER" build arg in the build step must match the | ||
# "--features pgXX" in the run step | ||
# "--features pgrxX" in the run step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (and all the other instances of pgXX
) shouldn't be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch. thanks. we're still reviewing this too.
…sion, should not have been renamed.
Yeah, that seems fine, and it definitely seems lower priority now that I realize the tcdioss website won't automatically update. Maybe we should open an issue to track following up on that and making a final decision. But "we discussed it and made a decision that will suffice for now" was the main thing I wanted. |
[[email protected]]: https://crates.io/crates/pgrxa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link was wrong in the orignal too. we'll fix it in post.
Alrighty, this is going to master right now as a squash merge, then merged into develop, then the repo here on GitHub will be renamed. Then published to crates.io from the master branch. |
This does the needful behind issue #1106