Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check root by uid #1044

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: check root by uid #1044

merged 1 commit into from
Feb 16, 2023

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Feb 16, 2023

In environment like docker containers, USER environment variable is not set, and therefore it might be a better idea to check root by UID instead of USER env variable.

@skyzh
fix: check root by uid
68b45a2 
Signed-off-by: Alex Chi <[email protected]>
@eeeebbbbrrrr eeeebbbbrrrr changed the base branch from master to develop February 16, 2023 14:55
@eeeebbbbrrrr
Copy link
Contributor

Please note that we prefer PRs against our develop branch, as noted in our CONTRIBUTING.md document. I've retargeted this one for you.

@skyzh
Copy link
Contributor Author

skyzh commented Feb 16, 2023

Thanks! Sorry for forgetting reading the contribution guide 🙈

eeeebbbbrrrr
eeeebbbbrrrr approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@eeeebbbbrrrr eeeebbbbrrrr merged commit 584c3a9 into pgcentralfoundation:develop Feb 16, 2023
@skyzh skyzh deleted the skyzh/check-root branch February 16, 2023 16:03
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeeebbbbrrrr eeeebbbbrrrr eeeebbbbrrrr approved these changes

@thomcc thomcc Awaiting requested review from thomcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyzh @eeeebbbbrrrr