Disable thin lto for dev builds by default in template #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We like PRs against the “develop” branch. Would you mind retargeting this? otherwise this is perfectly fine. I guess I’m not surprised thin LTO takes so long and we all forgot this was there. Thanks! |
eeeebbbbrrrr
approved these changes
Feb 6, 2023
Done |
|
CI is angry at the universe today, it seems. It's not this PR. We'll give it one more chance... |
JelteF
force-pushed
the
remove-thin-lto
branch
from
46ac0c9
to
b53f8a6
Compare
Done, I also removed the same line from all the examples in the repo. (Even though it was already commented out there, but the comment above it suggests to uncomment it) |
When changing something trivial in the hello world project created by `cargo pgx new`, it would take ~20 seconds to compile a dev build of the generated crate on my machine. This seemed way slower than it should be. It turns out that the thin LTO setting greatly inrceases compilation times. By disabling it, compilation time of the crate is only 1 second. As far as I can tell this setting was enabled initially as a workaround for this bug in Rust: rust-lang/rust#50007 Since this bug has been fixed since Rust 1.62, and current stable Rust is version 1.67, this PR removes the workaround.
JelteF
force-pushed
the
remove-thin-lto
branch
from
b53f8a6
to
9bb1b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing something trivial in the hello world project created by
cargo pgx new, it would take ~20 seconds to compile a dev build of thegenerated crate on my machine. This seemed way slower than it should be.
It turns out that the thin LTO setting greatly inrceases compilation
times. By disabling it, compilation time of the crate is only 1 second.
As far as I can tell this setting was enabled initially as a workaround
for this bug in Rust: rust-lang/rust#50007
Since this bug has been fixed since Rust 1.62, and current stable Rust
is version 1.67, this PR removes the workaround.