Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the libpq{,N}-dev package is removed in CI #1034

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Feb 3, 2023

In apt libpq-dev (or something like libpq5-dev) provides a pg_config binary, so that the client libraries can be located. We should remove that with the other stuff, so that we can catch cases wehre we are accidentally using thw wrong pg_config (see #981).

I also changed the globs to regexs, since I'm not sure how the globbing was working in the first place (shouldn't the glob expand to paths) and the internet says that it apt remove can be given a regex.

@BradyBonnette
Copy link
Contributor

Looks good, let's see what CI says

Copy link
Contributor

@BradyBonnette BradyBonnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

@thomcc thomcc merged commit 24ad866 into master Feb 3, 2023
@thomcc thomcc deleted the thomcc/no-pqdev branch February 3, 2023 23:51
@thomcc
Copy link
Contributor Author

thomcc commented Feb 3, 2023

Crap, that should have been against develop! Well, it's CI only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants