Support all the Rust "math" operations for Numeric<P, S> and AnyNumeric against primitives
#1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meric` on the left and each Rust primitive type on the right
thomcc
approved these changes
Feb 2, 2023
|
I'm gonna do the reverse to have the primitive on the lhs and call it a day. |
…meric` on the right and each Rust primitive type on the left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a complete oversight that these didn't get implemented as part of the initial Numeric support back in November 2022 as part of #851.
I was both shocked and awed to learn about this.
So here they are. All of Rust's "math" traits (Add, Sub, Mul, Div, Rem) are implemented for both
Numeric<P, S>andAnyNumericagainst all rust primitive types, with the primitive supported on both the left and right.In all cases, the resulting datatype is an
AnyNumeric.