Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the dependency on cstr_core #1025

Merged
merged 2 commits into from
Feb 1, 2023
Merged

remove the dependency on cstr_core #1025

merged 2 commits into from
Feb 1, 2023

Conversation

eeeebbbbrrrr
Copy link
Contributor

core::ffi::CStr and alloc::ffi::CString stabilized in rust v1.64, and since we have this loose requirement that 1.65 is pgx' bottom end supported version (b/c of plrust), we can now use these types (along with std::ffi::CStr(ing)) and drop the cstr_core dependency.

workingjubilee
workingjubilee approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

thomcc
thomcc approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tried to do this a few times, but was thwarted by 1.61 at the time.

@thomcc thomcc changed the title remove the dependency remove the dependency on cstr_core Feb 1, 2023
@eeeebbbbrrrr eeeebbbbrrrr merged commit ae2c690 into develop Feb 1, 2023
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Feb 2, 2023
Merged
@sumerman sumerman mentioned this pull request Feb 15, 2023
Merged
@eeeebbbbrrrr eeeebbbbrrrr deleted the remove-cstr_core-dep branch June 20, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

@thomcc thomcc thomcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eeeebbbbrrrr @thomcc @workingjubilee