Fix bug with converting a pg_sys::Datum into a pgrx::Date (#1177)

pgcentralfoundation · Jun 20, 2023 · f806a69 · f806a69
1 parent ecbf925
commit f806a69
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pgrx-tests/src/tests/datetime_tests.rs b/pgrx-tests/src/tests/datetime_tests.rs
@@ -573,4 +573,12 @@ mod tests {
         assert_eq!(result, Interval::new(6, 15, 42)?);
         Ok(())
     }
+
+    #[pg_test]
+    fn test_old_date() -> Result<(), Box<dyn std::error::Error>> {
+        let array = Spi::get_one::<Array<Date>>("SELECT ARRAY['1977-07-04']::date[]")?.unwrap();
+        let first = array.into_iter().next();
+        assert_eq!(first, Some(Some(Date::from_str("1977-07-04")?)));
+        Ok(())
+    }
 }
diff --git a/pgrx/src/datum/date.rs b/pgrx/src/datum/date.rs
@@ -63,7 +63,7 @@ impl TryFrom<pg_sys::Datum> for Date {
 
     #[inline]
     fn try_from(datum: pg_sys::Datum) -> Result<Self, Self::Error> {
-        pg_sys::DateADT::try_from(datum.value() as isize).map(|d| Date(d))
+        Ok(Date(datum.value() as pg_sys::DateADT))
     }
 }