-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
This switches to using the buffered version of |
Closing this as invalid |
@alanshaw It would not make any difference. |
Ah yes you're correct my apologies. |
@alanshaw @vaultec81 you guys reckon the buffered version is actually better then, as in less code with no loss in performance? I guess this PR overlaps with #9 so can either merge, or if you want to open a new one. |
Both versions are buffering. The current version using It would be better to stream it if possible. |
@alanshaw But you can't inject a partial ts fragment into the HLS stream, afaik, so what additional benefit would that have? The low latency play and seek functionality is something you get from HLS by design, as streams are always pre-fragmented and only need a handful of fragments to get going (this is what @vaultec81 mentioned above). Sorry if I'm missing the point! |
@moshisushi @alanshaw The issue I was experiencing was the stream was never closed. After some repeated testing I could not figure out why the stream wasn't ending. Which is why i put in correction: They are about the same performance/speed wise. |
@vaultec81 Thanks for this. This PR has been included in release 0.1.5. https://www.npmjs.com/package/hlsjs-ipfs-loader/v/0.1.5 Cheers! |
No description provided.