forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Infra] Display "Add metrics" callout for all containers without metr…
…ics (elastic#202220) ## Summary Closes elastic#196553. In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics. Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology. |View|Before|After| |-|-|-| |Overview|![Screenshot 2024-11-29 at 13 35 23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot 2024-11-29 at 13 33 15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)| |Metrics|![Screenshot 2024-11-29 at 13 35 30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot 2024-11-29 at 13 33 09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)| The PR also addresses an issue with the onboarding link used in the callout, where the `url` parameter was not properly preselecting any options. |Before|After| |-|-| |![Screen Recording 2024-11-29 at 13 37 05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen Recording 2024-11-29 at 13 33 26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)|
- Loading branch information
Showing
5 changed files
with
6 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters