Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.1.0. #83

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Release 4.1.0. #83

merged 2 commits into from
Aug 13, 2024

Conversation

dwsteele
Copy link
Collaborator

@dwsteele dwsteele commented Aug 5, 2024

  • Add PostgreSQL 17 support.
  • Remove support for PostgreSQL < 12.

We now have release notes in three separate places: GitHub releases, README.md, and CHANGELOG.txt. They are all different and I'd rather just standardize on Github release notes.

@dwsteele dwsteele requested a review from keithf4 August 5, 2024 03:50
@dwsteele dwsteele self-assigned this Aug 5, 2024
@dwsteele
Copy link
Collaborator Author

dwsteele commented Aug 5, 2024

BTW, I'm not planning to put rc* in the control file and create update scripts for RC versions. Just seems like a lot of churn with little or no benefit. Nobody should be running RC releases in production.

Copy link
Contributor

@artemgavrilov artemgavrilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Collaborator

@keithf4 keithf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update file looks good. Agreed on not providing updates on anything except mainline releases.

I agree the release notes can be left out of the readme. However, I do think they should still be in the repo as a file somewhere. For partman, I changed the CHANGELOG format to a markdown file. So now I can just copy-n-paste the same values from there into the release notes for the release. So the CHANGELOG is still the main location for all changes and users can still have access the entire change history from one easy to read place.
https://github.com/pgpartman/pg_partman/blob/master/CHANGELOG.md?plain=1

@dwsteele
Copy link
Collaborator Author

However, I do think they should still be in the repo as a file somewhere.

I'm not too convince by this. Lots of projects do not provide a top-level change log -- notably PostgreSQL. Multiple copies of the same data tend to get out of sync, which is what has already happened in set_user.

However, to move this along I've merged the release notes from README.md and CHANGELOG.txt into CHANGELOG.md. These notes are already out of sync with the Github release notes, but I'm not motivated to go back through and make those match. My vote would still be to nuke CHANGELOG.md entirely.

@dwsteele dwsteele merged commit 1dc57a8 into pgaudit:integration Aug 13, 2024
6 checks passed
@dwsteele dwsteele deleted the dev-release branch September 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants