-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.1.0. #83
Release 4.1.0. #83
Conversation
BTW, I'm not planning to put |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update file looks good. Agreed on not providing updates on anything except mainline releases.
I agree the release notes can be left out of the readme. However, I do think they should still be in the repo as a file somewhere. For partman, I changed the CHANGELOG format to a markdown file. So now I can just copy-n-paste the same values from there into the release notes for the release. So the CHANGELOG is still the main location for all changes and users can still have access the entire change history from one easy to read place.
https://github.com/pgpartman/pg_partman/blob/master/CHANGELOG.md?plain=1
I'm not too convince by this. Lots of projects do not provide a top-level change log -- notably PostgreSQL. Multiple copies of the same data tend to get out of sync, which is what has already happened in set_user. However, to move this along I've merged the release notes from README.md and CHANGELOG.txt into CHANGELOG.md. These notes are already out of sync with the Github release notes, but I'm not motivated to go back through and make those match. My vote would still be to nuke CHANGELOG.md entirely. |
We now have release notes in three separate places: GitHub releases, README.md, and CHANGELOG.txt. They are all different and I'd rather just standardize on Github release notes.