Restore Windows compatibility in Makefile #76
Conversation
There was a problem hiding this comment.
As discussed in email thread, would prefer that PGXS be the default and a flag required to not build that way.
If that's the only thing that's required for building on Windows that should be fine. If anything more needs to be done specifically for Windows, would prefer the suggestion from @pgguru to make a distinct Windows section by detecting the OS.
|
I've adjusted the logic to make PGXS the default case, and I tried to make the flag specific enough that others wouldn't use it by accident but if you feel it should be renamed let me know! |
Makefile
Outdated
| @@ -8,9 +8,16 @@ REGRESS = set_user | |||
|
|
|||
| LDFLAGS_SL += $(filter -lm, $(LIBS)) | |||
|
|
|||
| ifdef WINDOWS_DISUSE_PGXS | |||
There was a problem hiding this comment.
Since the non-pgxs build method still seems to be a thing some people are using, and that's all this is really providing an option for, I think it's probably good to just have this be the mode option for now. If things need to be more specialized for Windows, we can make those additions if/when that happens.
| ifdef WINDOWS_DISUSE_PGXS | |
| ifdef NO_PGXS |
There was a problem hiding this comment.
Sounds great to me!
Removal of the if conditional in Makefile between 3.0.0 and 4.0.0 breaks Windows Build Compatibility
On Windows, PostgreSQL Build is performed without USE_PGXS.
If PGXS is already defined before the make, Windows fails to generate win32ver.rc which is needed by win32ver.o, and causes the make target to fail.