Add pg10 compatibility for ProcessUtilityHook #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ab1f0c8 introduced the use of PlannedStmt in the ProcessUtilityHook. This change only affects versions >9.6. Commit 01fd6f8 introduced an extra argument (QueryEnvironment) in the ProcessUtilityHook. This change only affects versions >9.6. Rather than check for both changes, we assume that PlannedStmt usage signifies both >9.6 changes to avoid further ifdef magic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit postgres/postgres@ab1f0c8 introduced the use of PlannedStmt in the
ProcessUtilityHook. This change only affects versions >9.6.
Commit postgres/postgres@01fd6f8 introduced an extra argument (QueryEnvironment) in the
ProcessUtilityHook. This change only affects versions >9.6.
Rather than check for both changes, we assume that the PlannedStatement feature
encapsulates both >9.6 changes to avoid further ifdef magic.
Change tested with pgxs pointed at both pg10 and pg9.6.