-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During text edit, delete key tries to both delete selected text and any selected item in Object Explorer #7683
Comments
I'll also note that using the Find or Replace dialog in the query editor also has the same problem: entering some search or replacement text then Del also asks if you want to delete the table. |
Hi @paultobey, |
@adityatoshniwal Agreed. If I wanted to alter keyboard shortcuts I could work-around it. However, it seems reasonable to delete from Object Explorer when that control is focused and from the text editor when that is focused. For example, if we have two query editors open, we don't apply the Del key to both of them. I guess it feels like this should be the same case. |
I agree. Consider it as a workaround while we fix the issue. |
… table. Resolved delete object(shortcut key) affecting both text and Object Explorer items.pgadmin-org#7683
…and Object Explorer items. #7683
Much better in 8.10! Thanks! |
Issue fixed. Verified on snapshot build . Env: |
Describe the bug
In Windows (I have not tested on other OSes), when I'm editing query text, pressing the Del key to delete the currently selected text or to delete the next character in the text editor also attempts to delete the selected object in Object Explorer, generating an are-you-sure dialog (and a lot of frustration ;-)
To Reproduce
Open a database, select a table. Open query editor. Select some text in the query or place the cursor where the Del key makes sense for text editing. Press Del. The text editor operation occurs, but you also get an are-your-sure error about deleting the selected table.
Expected behavior
When the text editor uses a key, it should not pass it up the chain to other potential consumers like Object Explorer. It should just do the text editing operation.
Screenshots
State before pressing Del key. Note that I most-recently selected the text in the query editor, NOT the table in the Object Explorer so this isn't an issue of what is focused.
State after pressing Del key.
State after dismissing are-your-sure with No. Note that the Del operation did the right thing in the query editor.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: