Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved password functionality is NOT working if invalid value is passed for password file parameter in server configuration. #6934

Closed
yogeshmahajan-1903 opened this issue Nov 6, 2023 · 1 comment
Assignees
Milestone

Comments

@yogeshmahajan-1903
Copy link
Contributor

Please note that security bugs or issues should be reported to [email protected].

Describe the bug

Saved password functionality is NOT working if invalid value is passed for password file parameter in server configuration.

To Reproduce

Steps to reproduce the behavior:
Scenario 1

  1. Go to server definition and add password file parameter with invalid path for file.
  2. Now try to connect to there server, password prompt will presented.
  3. Enter the password and check the save password checkbox.
  4. Disconnect server and try to connect again. Again password is asked.

Scenario 2

  1. Add normal server.
    2.Connec to the server and check the save password checkbox.
    3.Go to server definition and add password file parameter with invalid path for file.
    4.Clear the saved password
    5.Now try to connect.
    6.User is able to connect without password though password file path is invalid(Do this step 2 times). Password is NOT cleared successfully.

Also check whether password is cleared or not in DB

Expected behavior

A clear and concise description of what you expected to happen.

Error message

If possible, include the full, unedited text of any error messages displayed.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context

Add any other context about the problem here.

@yogeshmahajan-1903 yogeshmahajan-1903 moved this from 🆕 New to 🏗 In Progress in Current Sprint (185) Nov 8, 2023
@yogeshmahajan-1903 yogeshmahajan-1903 self-assigned this Nov 8, 2023
@akshay-joshi akshay-joshi moved this from 🏗 In Progress to In Testing in Current Sprint (185) Nov 13, 2023
@akshay-joshi akshay-joshi added this to the 7.9 milestone Nov 13, 2023
@anilsahoo20 anilsahoo20 self-assigned this Nov 14, 2023
@akshay-joshi akshay-joshi moved this from In Testing to 🏗 In Progress in Current Sprint (185) Nov 21, 2023
@akshay-joshi akshay-joshi removed this from the 8.0 milestone Nov 21, 2023
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue Nov 21, 2023
…and server configuration has invalid pgpass file parameter.pgadmin-org#6934
@akshay-joshi akshay-joshi moved this from 🏗 In Progress to In Review in Current Sprint (185) Nov 22, 2023
akshay-joshi pushed a commit that referenced this issue Nov 23, 2023
…and server configuration has invalid pgpass file parameter. #6934
@akshay-joshi akshay-joshi moved this from In Review to In Testing in Current Sprint (185) Nov 23, 2023
@akshay-joshi akshay-joshi added this to the 8.1 milestone Nov 23, 2023
@anilsahoo20 anilsahoo20 self-assigned this Dec 1, 2023
@anilsahoo20
Copy link
Contributor

Tested and verified on Snapshot build: https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2023-12-01/
Package: arm64
Environment: macOs Ventura 13.5.1

@anilsahoo20 anilsahoo20 moved this from In Testing to ✅ Done in Current Sprint (185) Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants