-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status Monitoring - Quality Graph Tooltip Values #79
Closed
NOYB
wants to merge
3
commits into
pfsense:devel
from
NOYB:Status_Monitoring_-_Quality_Graph_Tooltip_Values
Closed
Status Monitoring - Quality Graph Tooltip Values #79
NOYB
wants to merge
3
commits into
pfsense:devel
from
NOYB:Status_Monitoring_-_Quality_Graph_Tooltip_Values
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know what may be planned for making the values more humanly friendly. So sharing this that I like. We mere humans just don't relate well to long strings of digits. Displaying the quality graph delay in milliseconds is much more human friendly. Probably a more elegant means but this will suffice for now.
I think the best implementation would be a lookup table of sorts, I'd have to play with the best way to populate it though. Possibly generate an array in local storage that can be referenced. |
Here it is implemented with local storage: 04d3576 Looked good in the testing I did. |
netgate-git-updates
pushed a commit
that referenced
this pull request
Aug 13, 2018
Also, sort plist. * BREAKING CHANGE: When downloading the free databases without a MaxMind account, you must either not have `AccountID`, `UserId`, or `LicenseKey` set in your configuration file or they must be set to the zero values previously recommended in our documentation. Any other value will cause an authorization error. * BREAKING CHANGE: The configuration options `Protocol`, `SkipPeerVerification`, and `SkipHostnameVerification` are no longer supported. If they are present in the configuration file, they will be ignored. HTTPS with peer and hostname verification will be used on all requests. * BREAKING CHANGE: The configuration file must have the `AccountID` or the deprecated `UserId` when downloading a paid database. Previously, when downloading the GeoIP Legacy Country database, you were able to only provide the `LicenseKey`. * IMPORTANT: `geoipupdate-pureperl.pl` has been removed and will no longer be distributed with `geoipupdate`. This Perl script had known issues and did not have feature parity with the C implementation. If you were using the Perl version, we recommend that you switch to the C version. If you are not able to do this, you may continue using the Perl version distributed with 2.5.0. * This program no longer uses the following endpoints: `/app/update_getipaddr`, `/app/update`, and `/app/update_secure`. `/geoip/databases/{edition_id}/update` is now used instead. * Fixed issue in `gu_strnlen()` dereferencing a pointer before checking that it was in array bounds. Issue found by fcntl. * We now update the default GeoIP.conf during installation so that directory paths match build parameters. Previously this config always said the data directory was under /usr/local/share which was not always accurate. * Improve the error checking and display the underlying reason for the error when possible. Reported by Jonathan Kosgei. GitHub #82. * Document that the `LockFile` is not removed from the filesystem after a successful exit from the program. GitHub issue #79. * Make default configuration directory agree with default installation directory.
netgate-git-updates
pushed a commit
that referenced
this pull request
May 27, 2022
Required for gitlab-ce 15.0.0. Changelog: https://github.com/ashkan18/graphlient/blob/master/CHANGELOG.md 0.5.0 (12/28/2020) #81: Make graphlient run on ruby 3.0 - @Burgestrand. #79: Added client testing docs - @GabrielDzul.
netgate-git-updates
pushed a commit
that referenced
this pull request
Sep 26, 2022
What's Changed * expose musicbrainz metadata if available by @tpeacock19 in #79 * Fix test failure with glib 2.73.3 by @pabs3 in #80
netgate-git-updates
pushed a commit
that referenced
this pull request
Nov 13, 2023
ChangeLog: https://nlnetlabs.nl/news/2023/Nov/08/unbound-1.19.0-released/ Features * Fix #850: [FR] Ability to use specific database in Redis, with new redis-logical-db configuration option. * Merge #944: Disable EDNS DO. Disable the EDNS DO flag in upstream requests. This can be helpful for devices that cannot handle DNSSEC information. But it should not be enabled otherwise, because that would stop DNSSEC validation. The DNSSEC validation would not work for Unbound itself, and also not for downstream users. Default is no. The option is disable-edns-do: no * Expose the script filename in the Python module environment 'mod_env' instead of the config_file structure which includes the linked list of scripts in a multi Python module setup; fixes #79. * Expose the configured listening and outgoing interfaces, if any, as a list of strings in the Python 'config_file' class instead of the current Swig object proxy; fixes #79. * Mailing list patches from Daniel Gröber for DNS64 fallback to plain AAAA when no A record exists for synthesis, and minor DNS64 code refactoring for better readability. * Merge #951: Cachedb no store. The cachedb-no-store: yes option is used to stop cachedb from writing messages to the backend storage. It reads messages when data is available from the backend. The default is no. Bug Fixes * Fix for version generation race condition that ignored changes. * Fix #942: 1.18.0 libunbound DNS regression when built without OpenSSL. * Fix for WKS call to getservbyname that creates allocation on exit in unit test by testing numbers first and testing from the services list later. * Fix autoconf 2.69 warnings in configure. * Fix #927: unbound 1.18.0 make test error. Fix make test without SHA1. * Merge #931: Prevent warnings from -Wmissing-prototypes. * Fix to scrub resource records of type A and AAAA that have an inappropriate size. They are removed from responses. * Fix to move msgparse_rrset_remove_rr code to util/msgparse.c. * Fix to add EDE text when RRs have been removed due to length. * Fix to set ede match in unit test for rr length removal. * Fix to print EDE text in readable form in output logs. * Fix send of udp retries when ENOBUFS is returned. It stops looping and also waits for the condition to go away. Reported by Florian Obser. * Fix authority zone answers for obscured DNAMEs and delegations. * Merge #936: Check for c99 with autoconf versions prior to 2.70. * Fix to remove two c99 notations. * Fix rpz tcp-only action with rpz triggers nsdname and nsip. * Fix misplaced comment. * Merge #881: Generalise the proxy protocol code. * Fix #946: Forwarder returns servfail on upstream response noerror no data. * Fix edns subnet so that queries with a source prefix of zero cause the recursor send no edns subnet option to the upstream. * Fix that printout of EDNS options shows the EDNS cookie option by name. * Fix infinite loop when reading multiple lines of input on a broken remote control socket. Addesses #947 and #948. * Fix #949: "could not create control compt". * Fix that cachedb does not warn when serve-expired is disabled about use of serve-expired-reply-ttl and serve-expired-client-timeout. * Fix for #949: Fix pythonmod/ubmodule-tst.py for Python 3.x. * Better fix for infinite loop when reading multiple lines of input on a broken remote control socket, by treating a zero byte line the same as transmission end. Addesses #947 and #948. * For multi Python module setups, clean previously parsed module functions in __main__'s dictionary, if any, so that only current module functions are registered. * Fix #954: Inconsistent RPZ handling for A record returned along with CNAME. * Fixes for the DNS64 patches. * Update the dns64_lookup.rpl test for the DNS64 fallback patch. * Merge #955 from buevsan: fix ipset wrong behavior. * Update testdata/ipset.tdir test for ipset fix. * Fix to print detailed errors when an SSL IO routine fails via SSL_get_error. * Clearer configure text for missing protobuf-c development libraries. * autoconf. * Merge #930 from Stuart Henderson: add void to log_ident_revert_to_default declaration. * Fix #941: dnscrypt doesn't work after upgrade to 1.18 with suggestion by dukeartem to also fix the udp_ancil with dnscrypt. * Fix SSL compile failure for definition in log_crypto_err_io_code_arg. * Fix SSL compile failure for other missing definitions in log_crypto_err_io_code_arg. * Fix compilation without openssl, remove unused function warning. * Mention flex and bison in README.md when building from repository source. PR: 275012 Reported by: [email protected] (maintainer)
netgate-git-updates
pushed a commit
that referenced
this pull request
Mar 4, 2024
ChangeLog: https://nlnetlabs.nl/news/2023/Nov/08/unbound-1.19.0-released/ Features * Fix #850: [FR] Ability to use specific database in Redis, with new redis-logical-db configuration option. * Merge #944: Disable EDNS DO. Disable the EDNS DO flag in upstream requests. This can be helpful for devices that cannot handle DNSSEC information. But it should not be enabled otherwise, because that would stop DNSSEC validation. The DNSSEC validation would not work for Unbound itself, and also not for downstream users. Default is no. The option is disable-edns-do: no * Expose the script filename in the Python module environment 'mod_env' instead of the config_file structure which includes the linked list of scripts in a multi Python module setup; fixes #79. * Expose the configured listening and outgoing interfaces, if any, as a list of strings in the Python 'config_file' class instead of the current Swig object proxy; fixes #79. * Mailing list patches from Daniel Gröber for DNS64 fallback to plain AAAA when no A record exists for synthesis, and minor DNS64 code refactoring for better readability. * Merge #951: Cachedb no store. The cachedb-no-store: yes option is used to stop cachedb from writing messages to the backend storage. It reads messages when data is available from the backend. The default is no. Bug Fixes * Fix for version generation race condition that ignored changes. * Fix #942: 1.18.0 libunbound DNS regression when built without OpenSSL. * Fix for WKS call to getservbyname that creates allocation on exit in unit test by testing numbers first and testing from the services list later. * Fix autoconf 2.69 warnings in configure. * Fix #927: unbound 1.18.0 make test error. Fix make test without SHA1. * Merge #931: Prevent warnings from -Wmissing-prototypes. * Fix to scrub resource records of type A and AAAA that have an inappropriate size. They are removed from responses. * Fix to move msgparse_rrset_remove_rr code to util/msgparse.c. * Fix to add EDE text when RRs have been removed due to length. * Fix to set ede match in unit test for rr length removal. * Fix to print EDE text in readable form in output logs. * Fix send of udp retries when ENOBUFS is returned. It stops looping and also waits for the condition to go away. Reported by Florian Obser. * Fix authority zone answers for obscured DNAMEs and delegations. * Merge #936: Check for c99 with autoconf versions prior to 2.70. * Fix to remove two c99 notations. * Fix rpz tcp-only action with rpz triggers nsdname and nsip. * Fix misplaced comment. * Merge #881: Generalise the proxy protocol code. * Fix #946: Forwarder returns servfail on upstream response noerror no data. * Fix edns subnet so that queries with a source prefix of zero cause the recursor send no edns subnet option to the upstream. * Fix that printout of EDNS options shows the EDNS cookie option by name. * Fix infinite loop when reading multiple lines of input on a broken remote control socket. Addesses #947 and #948. * Fix #949: "could not create control compt". * Fix that cachedb does not warn when serve-expired is disabled about use of serve-expired-reply-ttl and serve-expired-client-timeout. * Fix for #949: Fix pythonmod/ubmodule-tst.py for Python 3.x. * Better fix for infinite loop when reading multiple lines of input on a broken remote control socket, by treating a zero byte line the same as transmission end. Addesses #947 and #948. * For multi Python module setups, clean previously parsed module functions in __main__'s dictionary, if any, so that only current module functions are registered. * Fix #954: Inconsistent RPZ handling for A record returned along with CNAME. * Fixes for the DNS64 patches. * Update the dns64_lookup.rpl test for the DNS64 fallback patch. * Merge #955 from buevsan: fix ipset wrong behavior. * Update testdata/ipset.tdir test for ipset fix. * Fix to print detailed errors when an SSL IO routine fails via SSL_get_error. * Clearer configure text for missing protobuf-c development libraries. * autoconf. * Merge #930 from Stuart Henderson: add void to log_ident_revert_to_default declaration. * Fix #941: dnscrypt doesn't work after upgrade to 1.18 with suggestion by dukeartem to also fix the udp_ancil with dnscrypt. * Fix SSL compile failure for definition in log_crypto_err_io_code_arg. * Fix SSL compile failure for other missing definitions in log_crypto_err_io_code_arg. * Fix compilation without openssl, remove unused function warning. * Mention flex and bison in README.md when building from repository source. PR: 275012 Reported by: [email protected] (maintainer) (cherry picked from commit bb5a92c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know what may be planned for making the values more humanly friendly. So sharing this that I like.
We mere humans just don't relate well to long strings of digits. Displaying the quality graph delay in milliseconds is much more human friendly.
Probably a more elegant means but this will suffice for now.