Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -d and -v actually work, modify pfSense UI #630

Closed
wants to merge 5 commits into from

Conversation

zmanion
Copy link
Contributor

@zmanion zmanion commented Mar 19, 2019

Code was added to arpwatch to ignore CARP/VRRP MAC addresses when logging but the runtime option (-v) was not enabled. These changes also allow arpwatch to be run with -d for debug. Modify pfSense UI to support -v.

Here's the bug for upstream: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235415. Not sure how pfSense feels about getting out of sync with FreeBSD.

I've tested this on one pfSense system running 2.4.4-RELEASE-p2 and the UI works:

$ pgrep -lf arpwatch
1762 /usr/local/sbin/arpwatch -v -z -f /usr/local/arpwatch/arp_igb3.dat -i igb3 -m [email protected]
1533 /usr/local/sbin/arpwatch -v -z -f /usr/local/arpwatch/arp_igb2.dat -i igb2 -m [email protected]
1155 /usr/local/sbin/arpwatch -v -z -f /usr/local/arpwatch/arp_igb0.dat -i igb0 -m [email protected]

@rbgarga rbgarga requested a review from jim-p April 24, 2019 18:07
Copy link
Contributor

@jim-p jim-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes to the arpwatch port necessary? I'm not seeing any functional changes. I'd prefer to not be out of sync with FreeBSD if possible.

@zmanion
Copy link
Contributor Author

zmanion commented Apr 29, 2019

Changes to the port would be necessary, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235415. The port needs to actually accept the -v flag.
I understand not wanting to be out of sync with FreeBSD.

@jim-p
Copy link
Contributor

jim-p commented Apr 29, 2019

Looks like the changes to the port were just accepted, which is a good sign.

@rbgarga
Copy link
Member

rbgarga commented May 30, 2019

@zmanion I've cherry picked net-mgmt/arpwatch changes from upstream. Could you please remove any change to this port from this Pull Request and keep only changes to net-mgmt/pfSense-pkg-arpwatch ?

@zmanion
Copy link
Contributor Author

zmanion commented Jun 3, 2019

@rbgarga: Done, I left the change to bump PORTVERSION in the Makefile, not sure if that is correct or not.

@rbgarga
Copy link
Member

rbgarga commented Jun 3, 2019

I've manually merged it. Thanks!

@rbgarga rbgarga closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants