pfSense-pkg-LCDproc: Add a link status screen for each interface #377
Conversation
| case "scr_interfaces_link": | ||
| // We only want build_interface_link_list() to be | ||
| // called once per loop, and only if it's needed | ||
| if ($interfaceLinkList == null) |
There was a problem hiding this comment.
I guess you meant $ifLinkList here
| 'v4: <ip v4 address><br />' . | ||
| 'v6: <ip v6 address><br />' . | ||
| 'm: <mac address><br />' . | ||
| 'A 4‐row 20‐column display size, or higher, is recommended for this screen.' |
There was a problem hiding this comment.
Avoid adding html entities or tags inside the Help message. This string is considered to be added to translation files and it's easy to be broken if a translator make a mistake with them. setHelp() can be used as printf() so you can use parameters like %1$s as used in other places in pfSense main code
There was a problem hiding this comment.
Do you mean like this?
)->setHelp(
'This will create a seperate status screen for each inferface with four lines each:%1$s' .
'%2$sIFNAME%3$s: %2$slink status%3$s%1$s' .
'v4: %2$sip v4 address%3$s%1$s' .
'v6: %2$sip v6 address%3$s%1$s' .
'm: %2$smac address%3$s%1$s' .
'A 4%4$srow 20%4$scolumn display size, or higher, is recommended for this screen.',
['<br/>', '<', '>', '‐', ]
);
There was a problem hiding this comment.
Exactly! Can you please make the change?
|
Note: Merge combined with #376 |
|
@c-schwamborn Do you still have plans to work on this change? |
|
Sorry for the delay. Yes, I want to but my job is currently very demanding. I'll try to resolv the issue with the html tags. Btw. the whole code of the lcdproc plugin is full of those tags, I just wrote my changes like the rest of the code. Nevertheless I see your point, new code must not have the same issues. |
|
In an effort to improve the tracking of changes and bug/feature requests, we have decided to require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request. If you could, please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue. For more information, see https://doc.pfsense.org/index.php/Submitting_a_Pull_Request_via_Github Thanks! |
|
see pfsense redmine: https://redmine.pfsense.org/issues/8198 |
|
Please resubmit if you are able to address the requested changes. |
[ Robert Edmonds ] * Release 1.3.2. * Use protobuf 3.7.1 in the Travis-CI environment (#368). * Fix test suite build failure on newer versions of protobuf (#369). [ Ilya Lipnitskiy ] * Fix proto3 repeated scalar field default packing behavior (#330, #377). [ Adam Cozzette ] * Fix out-of-bounds read in scan_length_prefixed_data() (#375, #376). [ Jurriaan Bremer ] * Fix -Wdeclaration-after-statement warning in parse_oneof_member() (#360). [ Hayri Ugur Koltuk ] * Fix SIGSEGV in protobuf_c_message_check() on messages with unpopulated oneof members (#358). [ Italo Guerrieri ] * Do not allow tag values of 0 in protobuf messages, as these are not allowed by proto2 or proto3 (#299). The patch for version 1.3.1 is no longer required. Sort Makefile statements to pacify portlint. Reported by: portscout Sponsored by: Farsight Security, Inc.
* Provide --version option (#372) * Version information now within generated certificates like on *nix * Fixed issue where gen-dh overwrote existing files without warning (#373) * Fixed issue with ED/EC certificates were still signed by RSA (#374) * Added support for export-p8 (#339) * Clarified error message (#384) * 2->3 upgrade now errors and prints message when vars isn't found (#377)
Changes since 0.3.0: We reached v1.0.0 - fix!: Replace limit flag with paginate by @ankitpokhrel in #359 - fix!: Append components on edit instead of overriding by @ankitpokhrel in #368 - feat!: Append label to an issue, show labels at issue list view by @stchar in #300 - refactor!: Move boards and project list to subcommand by @ankitpokhrel in #314 - feat: Support custom fields on issue create by @ankitpokhrel in #319 - feat: Add support to read from .netrc by @adolsalamanca in #329 - feat: Add support for OS keyrings/-chains by @boyvanamstel in #348 - feat: Support auth with personal access tokens by @marek-veber / @ankitpokhrel in #327 - feat: Allow to set fixVersions on issue creation by @ankitpokhrel in #276 - feat: Allow insecure TLS by @ankitpokhrel in #305 - feat: Add --no-browser option to open cmd by @ankitpokhrel in #308 - feat: Add search option for boards on jira init by @ankitpokhrel in #322 - feat: Add issues unlink command by @sushilkg in #347 - feat: Support refresh for issues list by @GZLiew in #325 - feat: Ability to delete issue by @ankitpokhrel in #336 - feat: Allow to set custom fields on epic create by @ankitpokhrel in #364 - feat: Allow to edit release-info/fixVersions by @ankitpokhrel in #365 - feat: Allow removing labels on edit by @ankitpokhrel in #371 - feat: Support creating issues with custom subtask type by @danobi in #372 - feat: Allow removing component on edit by @ankitpokhrel in #374 - feat: Allow removing fixVersions on edit by @ankitpokhrel in #376 - feat: Support custom fields on issue edit by @ankitpokhrel in #377 - feat: Jira init non-interactive by @ankitpokhrel in #381 - feat: Show subtasks in issue view by @ankitpokhrel in #382 - feat: Allow project filter in raw jql by @ankitpokhrel in #395 - fix: Makefile compatiblity with Make 3.81 by @danmichaelo in #252 - fix: Config generation issue by @ankitpokhrel in #275 - fix(cfg): Strip trailing slash on server name by @ankitpokhrel in #295 - fix: Jira client should respect timeout opt by @ankitpokhrel in #304 - fix: Respect GLAMOUR_STYLE env on issue view by @ankitpokhrel in #317 - fix: Get subtask handle from config by @ankitpokhrel in #296 - fix: Jira wiki parser by @ankitpokhrel in #326 - fix: Display correctly columns in list sprint command help by @adolsalamanca in #320 - fix: Panic on empty sub-list by @ankitpokhrel in #330 - fix: Issue with assigning user by @ankitpokhrel in #321 - fix: OOM bug on issue view by @ankitpokhrel in #350 - fix: Assign parent key as is on edit by @ankitpokhrel in #351 - fix: Add additional check for total boards returned by @ankitpokhrel in #360 - fix: Issue with query param in user assignment by @ankitpokhrel in #380 - fix: Subtask clone by @ankitpokhrel in #383 - fix: editing issue with custom field in non interactive mode by @DrudgeRajen in #391 - dep: Upgrade charmbracelet/glamour to 0.5.0 by @ankitpokhrel in #309 - dep: Upgrade rivo/tview to latest by @ankitpokhrel in #310 - dep: Upgrade outdated packages by @ankitpokhrel in #311 - dep: Upgrade cobra to 1.4.0 by @ankitpokhrel in #373 - Use md ext for tmp file to trigger vim syntax by @ElementalWarrior in #318 Full Changelog: ankitpokhrel/jira-cli@v0.3.0...v1.0.0
The link screen is similar to the 'Interfaces' dashboard widget, displaying ipv4, ipv6, mac and link status for each interface.